Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_checkByline
function is a little weird in a few ways:It gets the job done, but I found it confusing to read and make sense of considering its modest length. I have consequently cleaned it up and re-organized the logic surrounding byline harvesting in general.
I included some basic documentation, but since I've never written a JavaScript doc-string before and I'm uncertain what the
matchString
argument is actually for, suggestions for improvement there are welcome.For reference, one can assume that
node
is an element becaause the_grabArticle
loop begins atdocumentElement
, and the_getNextNode
function which drives the loop always returns an element if it returns a node.